diff options
| author | srdusr <[email protected]> | 2025-09-26 22:07:00 +0200 |
|---|---|---|
| committer | srdusr <[email protected]> | 2025-09-26 22:07:00 +0200 |
| commit | 9a9aa8fe9d4f4f9b15860b45244e695942c90afd (patch) | |
| tree | a7a8289731d49713caeaf06f023ab04f78cc663c /crates/core/src/manager/mod.rs | |
| parent | b46dfa56504f62ecf969914dfed106bf587c4c4a (diff) | |
| download | srdwm-9a9aa8fe9d4f4f9b15860b45244e695942c90afd.tar.gz srdwm-9a9aa8fe9d4f4f9b15860b45244e695942c90afd.zip | |
Fake (headless) monitors, and fix new windows all opening in one spot
Two independent pieces landed together this pass - both real, both
scoped, see docs/TODO.md for the full narrative on each:
Fake monitors: a genuinely independent, additional wl_output with no DRM
connector/CRTC behind it at all - distinct from srd.monitor.split
(divides one real output's own placement rectangle). Researched niri's
own Headless backend first (cloned at ~/reference-wms/niri): its render()
never actually composites anything, a no-render stub for that project's
test suite only. This one is real: it renders whatever is placed on it,
on demand, whenever a zwlr_screencopy_manager_v1 client asks for a frame.
New crates/wayland/src/udev/virtual_heads.rs (create/remove a real Output
+ global, render-on-demand for screencopy, integrated into platform.rs's
monitors() as a genuine srdwm_core::Monitor so core placement/workspace
code needs zero special-casing). New IPC/CLI: srd dispatch create
fake-monitor <name> <w>x<h> / remove fake-monitor <name>. Core-side
request queue in crates/core/src/manager/fake_monitor.rs.
Placement bug, root-caused and fixed: every new window opened alone
landed in the exact same spot, "not at all like Windows" (reported live).
SmartPlacement::place tried a grid cell first, and grid's own cell count
is existing.len() + 1 - with nothing else open (opening one app at a
time, the ordinary case), that's always 1, so a 1x1 grid returns the same
single cell forever regardless of session history. Cascade had the same
bug in a second form (its own step was existing.len() % max_steps, also
always 0 with nothing open). Fixed: WindowManager::next_cascade_step (a
Cell - add_window's own target_monitor stays borrowed across the call)
advances on every real placement and is never reset by a window closing;
place() now skips grid entirely when nothing else is open, going
straight to cascade, since grid's real job (dividing space among
concurrent windows) has nothing to divide when there's no concurrency.
Full workspace build/test/clippy clean (223 core / 141 wayland / 29
platform / 24 ctl / 28 config / 10 x11 tests, 0 failed, 0 clippy
warnings), built and installed.
Diffstat (limited to 'crates/core/src/manager/mod.rs')
| -rw-r--r-- | crates/core/src/manager/mod.rs | 23 |
1 files changed, 23 insertions, 0 deletions
diff --git a/crates/core/src/manager/mod.rs b/crates/core/src/manager/mod.rs index a5cde36..c82bced 100644 --- a/crates/core/src/manager/mod.rs +++ b/crates/core/src/manager/mod.rs @@ -80,6 +80,12 @@ pub struct WindowManager { /// ever learn) to a specific window. See `input_pin.rs`'s own doc /// comment. pin_input_requests: Vec<(i32, Option<WindowId>)>, + /// Same cross-boundary-request pattern, for fake (fully virtual, no + /// real hardware) monitors - see `fake_monitor.rs`'s own doc comment + /// and `crates/wayland/src/udev/virtual_heads.rs`'s module doc + /// comment for the full design. + create_fake_monitor_requests: Vec<(String, u32, u32)>, + remove_fake_monitor_requests: Vec<String>, /// Same cross-boundary-request pattern as `output_position_requests` /// just above, for enable/disable - see `request_output_enabled`'s /// own doc comment for why this is keyed by name, not `MonitorId`. @@ -170,6 +176,19 @@ pub struct WindowManager { layouts: HashMap<String, Box<dyn Layout>>, pub tiling: TilingConfig, pub placement: PlacementConfig, + /// Feeds `SmartPlacement::place`'s own `cascade_step` - advances on + /// every real cascade/grid placement, session-long, never reset by a + /// window closing. See `SmartPlacement::cascade`'s own doc comment + /// for the reported "every window opens in the same spot" bug this + /// exists to fix. A `Cell`, not a plain field: `add_window`'s own + /// `target_monitor` is a `&Monitor` borrowed from `self.monitors` and + /// stays alive across the same call that needs to bump this counter, + /// so a plain `&mut self` write there would conflict with that live + /// immutable borrow - interior mutability sidesteps it without + /// restructuring the borrow, the same reasoning any of this + /// compositor's other `Rc<RefCell<...>>`-style shared-mutation points + /// already accept. + next_cascade_step: std::cell::Cell<u32>, /// Whether geometry changes made via `toggle_maximize`/`toggle_fullscreen` /// should be animated. Read from `general.animations`; a backend's open /// animation is gated on this too, since core has no notion of "open". @@ -410,6 +429,8 @@ impl WindowManager { monitors: Vec::new(), output_position_requests: Vec::new(), pin_input_requests: Vec::new(), + create_fake_monitor_requests: Vec::new(), + remove_fake_monitor_requests: Vec::new(), output_enable_requests: Vec::new(), disabled_monitors: HashMap::new(), monitor_splits: HashMap::new(), @@ -460,6 +481,7 @@ impl WindowManager { layouts, tiling: TilingConfig::default(), placement: PlacementConfig::default(), + next_cascade_step: std::cell::Cell::new(0), animations_enabled: true, animation_duration_ms: 200, shadows_enabled: true, @@ -510,6 +532,7 @@ impl WindowManager { mod capture; mod dragresize; +mod fake_monitor; mod focus; mod hittest; mod input_pin; |