srdusr
aboutsummaryrefslogtreecommitdiffstats
path: root/crates/wayland/src/udev/mod.rs
diff options
context:
space:
mode:
authorsrdusr <[email protected]>2025-10-07 22:20:00 +0200
committersrdusr <[email protected]>2025-10-07 22:20:00 +0200
commit9f07715b469a481849ee35ffa33d6dab34356c7d (patch)
tree7080f57115b9ea3ccab43e458c34aa2acec74501 /crates/wayland/src/udev/mod.rs
parent4eb36873d4ca4b0faf0e54dbeab8f5f6450dd704 (diff)
downloadsrdwm-9f07715b469a481849ee35ffa33d6dab34356c7d.tar.gz
srdwm-9f07715b469a481849ee35ffa33d6dab34356c7d.zip
Fix intermittent cursor ghosting when crossing between monitors
Live report: the real cursor sometimes leaves a brief ghost behind right after moving between monitors. The bare-metal render loop already forces a full repaint (ages = [0, 0]) on a workspace switch or any window move/ resize/open/close/restack, both added earlier for the same underlying gap: the damage tracker's own element diffing doesn't always catch a vacated region on its own. Neither reset noticed the pointer leaving one monitor for another - no window moved, no workspace changed - so that head's own vacated cursor-sized region was left entirely to the tracker's diffing, intermittently. Adds UdevState::last_cursor_head, compared each frame the same way the other two resets are; only the head the pointer just left gets forced back to ages = [0, 0] (the newly-entered head draws a genuinely new element there and diffs correctly on its own).
Diffstat (limited to 'crates/wayland/src/udev/mod.rs')
-rw-r--r--crates/wayland/src/udev/mod.rs22
1 files changed, 22 insertions, 0 deletions
diff --git a/crates/wayland/src/udev/mod.rs b/crates/wayland/src/udev/mod.rs
index b0a2639..22df0e1 100644
--- a/crates/wayland/src/udev/mod.rs
+++ b/crates/wayland/src/udev/mod.rs
@@ -278,6 +278,28 @@ pub(crate) struct UdevState {
/// `None` before the first frame, same reasoning as `last_rendered_
/// workspace` above (renders fully regardless).
pub(crate) last_rendered_layout: Option<u64>,
+ /// Index into `heads` of whichever head the pointer was actually drawn
+ /// on last frame (`None` before the first frame, or if it was on none
+ /// of them). Compared each frame in `render_udev_frame`, same pattern
+ /// as `last_rendered_workspace`/`last_rendered_layout` above, so that
+ /// when the pointer crosses from one monitor to another the head it
+ /// just *left* gets its own `ages` forced back to `[0, 0]` too.
+ ///
+ /// Needed because neither of those two other resets notices this
+ /// transition at all: no window moved, and the workspace didn't
+ /// change, so both stay silent while the cursor sprite simply drops
+ /// out of that head's `custom_elements` list from one frame to the
+ /// next. That leaves the departing head's vacated cursor-sized region
+ /// resting entirely on `OutputDamageTracker`'s own element diffing --
+ /// already documented, for the same "an element disappeared" shape of
+ /// bug on a window vacating part of the screen, as not reliable on its
+ /// own (see `layout_signature`'s own doc comment above `render_udev_
+ /// frame`). Reported live as an intermittent cursor "ghost" briefly
+ /// left behind right after moving the pointer between monitors --
+ /// intermittent because it depends on whatever else that head's own
+ /// diffing already had queued that frame, exactly like the window
+ /// case did.
+ pub(crate) last_cursor_head: Option<usize>,
/// Set only when `SRDWM_GPU=1` and `gpu::probe` succeeds on this
/// hardware - see that function's own doc comment for exactly what
/// it does and does not do yet. `None` (the default, every session