srdusr
aboutsummaryrefslogtreecommitdiffstats
path: root/tests/test_dissector.cpp
diff options
context:
space:
mode:
authorsrdusr <[email protected]>2025-07-01 00:40:00 +0200
committersrdusr <[email protected]>2025-07-01 00:40:00 +0200
commit407249eb5d654b5a951c43bc1722fd397d5d922c (patch)
treec367bf95c3855152d477a7eed5e709b3094a427c /tests/test_dissector.cpp
parent9046e6a10fd2d987cf6f6dc601ed3a75d286793f (diff)
downloadpacketeer-407249eb5d654b5a951c43bc1722fd397d5d922c.tar.gz
packeteer-407249eb5d654b5a951c43bc1722fd397d5d922c.zip
Add FTP, SMTP, TFTP, and IGMP; fix an IGMPv3 group-address misparse
FTP and SMTP share HTTP's line-based response-code-or-command shape but keep their own command vocabularies in separate files rather than sharing a parser. FTP passwords are shown as-is, not redacted - FTP sends them in the clear regardless, matching Wireshark's own behavior. TFTP is a small binary opcode protocol (RFC 1350) instead. IGMP sits directly on IP like ICMP, so it's dispatched by protocol number rather than through the port-keyed L7Registry the other three use. Live-verified: FTP/SMTP against minimal real TCP servers written for this (nothing installed locally), a full command/response exchange decoded correctly in both directions. TFTP against a real atftpd server and atftp client - the RRQ decoded correctly even though the transfer itself didn't complete (an atftpd sandbox issue, not this code). IGMP against real multicast traffic on wlp1s0, including a genuine query from the actual router. That live IGMP traffic caught a real bug before it shipped further: parse_igmp() read bytes[4:8] as a group address for every message type, but IGMPv3 reports use those bytes for Reserved+RecordCount instead - a real V3 report showed "group=0.0.0.1" (0 reserved, 1 record, misread as an IP). Fixed by only populating group for the types where it's genuinely an address; re-verified against the same live traffic, and a regression test locks in the exact pattern.
Diffstat (limited to 'tests/test_dissector.cpp')
0 files changed, 0 insertions, 0 deletions