srdusr
aboutsummaryrefslogtreecommitdiffstats
path: root/include/wireframe
diff options
context:
space:
mode:
authorsrdusr <[email protected]>2026-05-29 22:56:00 +0200
committersrdusr <[email protected]>2026-05-29 22:56:00 +0200
commit719b7f439c1c8c76d0573b34daa329061c9ad8a6 (patch)
treed6a1ad5546332859a717bdadbfd72ff4041e18f3 /include/wireframe
parente41dade9ac3bbd7ffbc1eec826801af1a38d8b9e (diff)
downloadpacketeer-719b7f439c1c8c76d0573b34daa329061c9ad8a6.tar.gz
packeteer-719b7f439c1c8c76d0573b34daa329061c9ad8a6.zip
Fix IPv4/IPv6 fragment continuation data being decoded as fake transport headers
A real correctness bug, not just missing visibility: a non-first fragment's payload is pure continuation data with no TCP/UDP/ICMP header in it at all, but it was being handed to the transport parsers unconditionally, which could misread arbitrary payload bytes as port numbers, sequence numbers, etc. and print a plausible-looking but entirely fake decode. IPv4 gained identification/more_fragments/fragment_offset fields; a nonzero offset now stops summarize_packet before transport dispatch, reporting the fragment instead. IPv6 expresses fragmentation as an extension header instead, so the fix lives in walk_ipv6_extension_headers(): it already walked past Fragment headers, but never checked the offset before continuing on as if a transport header followed - the same bug, reached through a different path. Fixed with an ESP-style hard stop on a nonzero offset. Caught and fixed a second bug while writing the first fix, before it ever ran: the fragment's Identification field was a loop-local variable, discarded the moment the walk continued past a *first* fragment (offset zero) to keep decoding the real payload underneath -- every later return reported no fragment id even though one applied. Fixed by hoisting it to a variable that persists across iterations, the same category of mistake as an earlier IGMPv3 bug. Fuzzed afterward regardless (fuzz_ipv4, fuzz_ipv6, fuzz_summarize, ~16.8M combined runs) - clean. Live-verified with a real 4000-byte ping to the local gateway over the actual 1500-MTU interface: both directions fragmented into 3 pieces each, the first decoded normally with a fragmentation note, and the continuation fragments correctly showed only fragment metadata, no fake ICMP decode attempted.
Diffstat (limited to 'include/wireframe')
0 files changed, 0 insertions, 0 deletions