diff options
| author | srdusr <[email protected]> | 2026-06-09 15:46:00 +0200 |
|---|---|---|
| committer | srdusr <[email protected]> | 2026-06-09 15:46:00 +0200 |
| commit | a2362fc08c31b23fb971279f8b160555123ad2f6 (patch) | |
| tree | 6e7adf22167987f685d122f77f56b31a2ce988b2 /internal/proxy/bodyrules_test.go | |
| parent | 9028f8175bda63d6a85e5a2dee2b4039020317a4 (diff) | |
| download | mitmux-a2362fc08c31b23fb971279f8b160555123ad2f6.tar.gz mitmux-a2362fc08c31b23fb971279f8b160555123ad2f6.zip | |
Body match-and-replace rules
Extends match-and-replace rules to request/response bodies, not just
headers. A body rule materializes the body into memory (bounded by
the same maxCaptureBytes cap as history capture) instead of streaming
it straight through - the opposite of the normal path, so it's only
paid when a body rule is actually configured. A body over the cap
passes through byte-exact and unmodified rather than being partially
rewritten.
Response Content-Length is recomputed explicitly when a rule changes
body length: unlike http.Request.Write, http.ResponseWriter doesn't
derive it from resp.ContentLength on its own, so a stale header would
otherwise corrupt response framing for the client.
The history audit trail still shows the original, pre-rule bytes on
both legs; only the wire traffic reflects the rewrite. Verified live
against a real daemon: origin receives the rewritten request body,
client receives the rewritten response body with correct
Content-Length, and history keeps the unmodified bytes.
Adds a Part selector (header/body) to the Rules add/edit form and
table in the TUI.
Diffstat (limited to 'internal/proxy/bodyrules_test.go')
| -rw-r--r-- | internal/proxy/bodyrules_test.go | 86 |
1 files changed, 86 insertions, 0 deletions
diff --git a/internal/proxy/bodyrules_test.go b/internal/proxy/bodyrules_test.go new file mode 100644 index 0000000..2a62855 --- /dev/null +++ b/internal/proxy/bodyrules_test.go @@ -0,0 +1,86 @@ +package proxy + +import ( + "bytes" + "io" + "strings" + "testing" + + "mitmux/internal/rules" +) + +func TestApplyBodyRulesRewrites(t *testing.T) { + body := io.NopCloser(strings.NewReader(`{"admin":false}`)) + rs := []rules.Rule{{Enabled: true, Part: "body", Match: "false", Replace: "true"}} + + newBody, newLen, applied, err := applyBodyRules(body, rs) + if err != nil { + t.Fatalf("unexpected error: %v", err) + } + if !applied { + t.Fatal("expected applied=true") + } + got, _ := io.ReadAll(newBody) + want := `{"admin":true}` + if string(got) != want { + t.Errorf("body = %q, want %q", got, want) + } + if newLen != int64(len(want)) { + t.Errorf("newLength = %d, want %d", newLen, len(want)) + } +} + +func TestApplyBodyRulesNilBody(t *testing.T) { + newBody, newLen, applied, err := applyBodyRules(nil, []rules.Rule{{Enabled: true, Part: "body"}}) + if err != nil { + t.Fatalf("unexpected error: %v", err) + } + if applied || newBody != nil || newLen != 0 { + t.Errorf("expected no-op for nil body, got body=%v len=%d applied=%v", newBody, newLen, applied) + } +} + +func TestApplyBodyRulesOversizedPassesThroughUnmodified(t *testing.T) { + // One byte over the cap: exercises the "too large to safely + // rewrite" path, which must reconstruct the ORIGINAL bytes exactly + // (not the rule applied, not truncated, not corrupted) since the + // whole point is refusing to guess at a partial rewrite. + big := bytes.Repeat([]byte("a"), maxCaptureBytes+1) + body := io.NopCloser(bytes.NewReader(big)) + rs := []rules.Rule{{Enabled: true, Part: "body", Match: "a", Replace: "b"}} + + newBody, newLen, applied, err := applyBodyRules(body, rs) + if err != nil { + t.Fatalf("unexpected error: %v", err) + } + if applied { + t.Fatal("expected applied=false for an oversized body") + } + if newLen != 0 { + t.Errorf("expected newLength=0 (caller must not touch Content-Length) for an unapplied rewrite, got %d", newLen) + } + got, err := io.ReadAll(newBody) + if err != nil { + t.Fatalf("reading reconstructed body: %v", err) + } + if !bytes.Equal(got, big) { + t.Errorf("reconstructed body does not match original: got %d bytes, want %d bytes, equal=%v", + len(got), len(big), bytes.Equal(got, big)) + } +} + +func TestApplyBodyRulesExactlyAtCapStillApplies(t *testing.T) { + // Exactly at the cap (not over it) should still be treated as + // "fits" and get the rule applied - the +1 in the LimitReader is + // what distinguishes "at the limit" from "over the limit". + body := io.NopCloser(strings.NewReader(strings.Repeat("a", maxCaptureBytes))) + rs := []rules.Rule{{Enabled: true, Part: "body", Match: "a", Replace: "b"}} + + _, _, applied, err := applyBodyRules(body, rs) + if err != nil { + t.Fatalf("unexpected error: %v", err) + } + if !applied { + t.Error("expected applied=true for a body exactly at the cap") + } +} |