diff options
| author | srdusr <[email protected]> | 2026-05-15 19:48:00 +0200 |
|---|---|---|
| committer | srdusr <[email protected]> | 2026-05-15 19:48:00 +0200 |
| commit | dd1621c0077e079e0693f16fe83f17d50338216e (patch) | |
| tree | 411a06d723a16aff1077d5d3e724680436aac85a /internal/ipc/server.go | |
| parent | d7d50ae9902d69b2e52d446684b5ab01a5ecab1e (diff) | |
| download | mitmux-dd1621c0077e079e0693f16fe83f17d50338216e.tar.gz mitmux-dd1621c0077e079e0693f16fe83f17d50338216e.zip | |
Stop mislabeling truncated captures as "exact"
internal/proxy/tee.go's teeConn silently drops bytes past
maxCaptureBytes (10 MiB) but callers unconditionally marked the result
"exact" anyway. Confirmed live: proxying a 15 MiB response worked
correctly end-to-end (the client got the full, real 15 MiB - proxying
itself is unbounded, only storage is capped), but the stored history
entry was exactly 10485760 bytes with response_exact=1 still set. For a
tool whose core value proposition is "raw bytes are the source of
truth," a silently truncated capture presented as complete could hide
the very evidence a smuggling or parser-differential investigation is
looking for in the tail of a large body - and give false confidence
that it isn't there.
teeConn.Take() now returns (data, truncated) instead of just data;
truncated is true whenever a Read had to drop bytes because the buffer
was already at cap. Every caller (proxy.go's forward() on both the
request and response side, repeat.go's sendRaw for Repeater/Intruder)
now folds truncated into exact - a truncated capture is never marked
exact - and additionally threads a distinct RequestTruncated/
ResponseTruncated bool through store.Entry, ipc.EntryDetail, and the
TUI, since "truncated" and "reconstructed" (HTTP/2, which never had
wire-exact bytes to begin with) are different situations worth telling
apart: a truncated capture is still real wire bytes, just incomplete,
not a synthesized reconstruction. The detail/repeater views now show
"truncated (hit capture size limit)" specifically rather than lumping
it in with "reconstructed", which would have implied more
transformation happened than actually did.
Schema: history gains request_truncated/response_truncated columns via
the same ALTER-TABLE-and-ignore-duplicate-column pattern already used
for source/flagged, so existing databases upgrade in place.
Verified live: a target server returning a 15 MiB body (over the 10 MiB
cap) proxied through cleanly - full body reached the client - while the
stored entry shows length=10485760, response_exact=0,
response_truncated=1 (previously would have shown response_exact=1);
the TUI's Detail view correctly displays "Response (10485760 bytes,
truncated (hit capture size limit))" instead of "exact".
go build/vet/gofmt/test/mod tidy all clean.
Diffstat (limited to 'internal/ipc/server.go')
| -rw-r--r-- | internal/ipc/server.go | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/internal/ipc/server.go b/internal/ipc/server.go index 94073da..2879b24 100644 --- a/internal/ipc/server.go +++ b/internal/ipc/server.go @@ -312,6 +312,7 @@ func detailFromEntry(e *store.Entry) *EntryDetail { }, RequestRaw: e.RequestRaw, ResponseRaw: e.ResponseRaw, RequestExact: e.RequestExact, ResponseExact: e.ResponseExact, + RequestTruncated: e.RequestTruncated, ResponseTruncated: e.ResponseTruncated, } } |