srdusr
aboutsummaryrefslogtreecommitdiffstats
path: root/crates/wayland/src/decoration
AgeCommit message (Collapse)AuthorFilesLines
2025-04-03Fix border corner rendered as a solid wedge instead of a ringsrdusr4-56/+216
round_top_corners/round_bottom_corners only ever cut pixels *outside* the shared corner radius (the rounded outer silhouette). Nothing cut anything *inside* it, so a border strip's own "extra" rows (present whenever corner_radius > border_width) stayed a solid filled disk out to the centre column/row, then hit clip_middle_beyond_thickness's hard, unblended rectangular cut right at the disk's own most opaque point - a clean right-angle step, not a curve. Confirmed live, zoomed: a real square notch bitten into an otherwise smooth arc, reported as "squares on the inside corners of each vertex." Added carve_inner_corner_pixel, the same smoothstep falloff as the existing outer cut but inverted (cuts near the centre instead of far from it), applied at radius - border_width so the corner becomes a genuine ring of ~border_width visible thickness tapering smoothly to transparent, instead of a filled wedge. Only render_border_top/ render_border_bottom pass an inner_radius; the titlebar's own corner and the lock-screen box keep their existing solid-disk behaviour, which is correct for a single flat-coloured panel with nothing of a different colour underneath needing to show through. Also generalizes round_top_corners with an explicit center_col parameter, mirroring the existing center_row shift: the titlebar's own corner circle was never shifted horizontally to match the border strip's (only vertically), leaving a border_width-wide sliver of the titlebar's own misaligned curve poking through at the seam. border_top_and_titlebar_corners_meet_without_a_seam and border_top_curve_actually_closes_within_the_side_strips_own_width updated to match: both now compare the correct corresponding columns (the titlebar's own buffer starts border_width columns inside the border strip's), and the latter no longer demands exact 255 opacity at a point that legitimately sits within the new inner cut's own antialiasing band.
2025-03-15Fix half-pixel seam between border-strip and content corner curvessrdusr1-6/+32
The border-strip bitmap's own corner rounding (corners.rs's blend_ corner_pixel) and the client-content mask's corner rounding (rounded_corners_pixman.rs's apply_corner_mask) are two independent implementations that need to trace the exact same circle where a window's border meets its own rounded content. Their falloff math was already identical (same smoothstep construction over the same radius-1..radius+1 band), but apply_corner_mask samples each pixel at its own center (x as f32 + 0.5) - the standard rasterization convention, matching the GLES shader used for the winit backend -- while blend_corner_pixel sampled at the raw integer coordinate (x as f32), a systematic half-pixel offset between the two curves. round_top_corners/round_bottom_corners had a compensating "- 1" baked into their own right-edge/bottom-edge center calculation, tuned against the old, uncentered convention. Confirmed live at extreme zoom: a small but real right-angle step partway along an otherwise smooth arc, right where the two curves are supposed to meet -- reported as "squares on the inside corners of each vertex." Added the missing + 0.5 to blend_corner_pixel and removed the two compensating "- 1"s (both call sites), which now line up exactly with apply_corner_mask's own clamp-derived center for the same corner (width - r / height - r, not width - r - 1 / height - r - 1). All 378 existing tests pass unchanged - none of them assert exact pixel positions this shifts by half a pixel.
2025-02-18Fix clippy warnings surfaced by the mergesrdusr2-4/+5
Pre-existing issues in the uncommitted rust-rewrite work (unused imports, over-arity glyph-drawing functions, a couple of complex inline types, or_insert_with(T::default) instead of or_default(), and one unsimplified test-only arithmetic expression), plus two imports left unused by switching to or_default(). None of these are behavior changes. Full workspace build + clippy -D warnings + test suite (378 tests) all green after this.
2025-02-15Checkpoint: preserve all uncommitted rust-rewrite worktree worksrdusr8-0/+2057
Safety commit before reconciling this worktree with main, which has diverged with its own separate fixes today. Nothing here is reviewed or curated yet - this exists purely so none of this work can be lost to a git operation, disk issue, or worktree cleanup while that reconciliation happens.