From 4933f669f8338ca5e4c64cf0294818c5d15ed122 Mon Sep 17 00:00:00 2001
From: srdusr <99972264+srdusr@users.noreply.github.com>
Date: Wed, 14 Jan 2026 22:23:00 +0200
Subject: Make every passage long enough to be worth timing, and credit all of
them
The dataset's median passage was 69 characters, about twelve words, which is
over in twelve seconds at an ordinary speed. Some packs were worse: shell had
a median of 46 and a shortest entry of 17. That is the reason packs felt
small. It was not the number of entries, which was 15 to 37 per pack, but the
length of each one.
Multiplayer had already hit this and worked around it: load_race_texts
filters to 120 characters or more. That filter left only 61 of 350 passages
eligible, 38 of them from two packs, so races repeated constantly and four
packs could never come up at all.
Both halves are fixed.
Content: 104 longer passages added across every pack. The command packs get
whole pipelines rather than single flags, which is how the tools are actually
used and what the explanations were always for. Prose packs get passages that
run 150 to 320 characters.
Selection: a floor of 120 characters. Prose packs draw from their long
entries where a pack holds at least five, so no pack is reduced to the same
few passages. The command packs chain consecutive entries into one drill,
which is the natural shape for them, and the explanations are collected so
each line is still described.
Measured over 400 draws per pack, every category now runs a median of 146 to
218 characters with a shortest draw of 120. The race pool went from 61 of 350
to 130 of 454.
Attribution: 24 passages had none and displayed nothing at all under the
text. They now say Unknown, which is the honest answer for a fact written for
the pack, and the pangram is credited as one. The results and typing screens
both fall back to Unknown rather than rendering an empty line, and the pack
name is shown beside the source.
Multiplayer results, three fixes:
- PB never appeared. A race has no mode of its own, so modeKey was undefined,
so recordResult never ran. Races share one key, because the passage is
whatever the server dealt and a per-passage best would never be beaten.
- Play Again started a solo test. A race carries standings and a solo run does
not, so the results screen can tell them apart and now queues for another
race. The end screen's own cleanup leaves the old room first.
- CONSISTENCY was the longest label on the screen and made the accuracy
column wider than the WPM column opposite it. It reads CON.
RaceText carries the pack name so the results can show it for a race the same
way single player does.
24 Rust tests and 3 browser tests pass.
---
web/src/screens/endScreen.js | 20 +++++++++++---------
web/src/screens/multiplayerScreen.js | 6 +++---
web/src/screens/typingGame.js | 6 +++---
3 files changed, 17 insertions(+), 15 deletions(-)
(limited to 'web/src/screens')
diff --git a/web/src/screens/endScreen.js b/web/src/screens/endScreen.js
index aebd62b..fa3b188 100644
--- a/web/src/screens/endScreen.js
+++ b/web/src/screens/endScreen.js
@@ -3,7 +3,6 @@ import { escapeHtml } from '../util.js';
import { attachTooltips } from '../tooltip.js';
import { onThemeChange } from '../theme.js';
import { renderSiteFooter } from '../siteFooter.js';
-import { renderAdSlot } from '../adSlot.js';
import { recordResult } from '../pb.js';
import { recordTest } from '../profileStats.js';
import { renderCornerRail } from '../cornerRail.js';
@@ -11,7 +10,7 @@ import { renderTopRail } from '../topRail.js';
import { submitTestResult } from '../auth.js';
import { detectDeviceType } from '../deviceDetect.js';
-export function renderEndScreen(root, { stats, text, attribution, explanation, standings, onShowPrivacy, onStandingsUpdate, onLeaveRace, userInput, charTimings, keypressHistory, modeKey, onPlayAgain, onMainMenu, onShowStats, onShowPlaceholder, onShowAccount, onShowLeaderboard, onShowFriends, onShowMultiplayer, onShowStore }) {
+export function renderEndScreen(root, { stats, text, attribution, category, explanation, standings, onShowPrivacy, onStandingsUpdate, onLeaveRace, userInput, charTimings, keypressHistory, modeKey, onPlayAgain, onMainMenu, onShowStats, onShowPlaceholder, onShowAccount, onShowLeaderboard, onShowFriends, onShowMultiplayer, onShowStore }) {
// Monkeytype's four-way split. "Extra" is anything typed past the end of
// the passage, "missed" is passage left untyped - neither is visible in
// a plain correct/incorrect pair, and the two mean very different things
@@ -21,7 +20,13 @@ export function renderEndScreen(root, { stats, text, attribution, explanation, s
const missedChars = Math.max(0, (text || '').length - typedLen);
const graphPoints = buildGraphPoints(charTimings, stats, keypressHistory);
const consistency = calculateConsistency(graphPoints);
- const { isNewBest, previous } = recordResult(modeKey, stats.wpm);
+ const isRace = Array.isArray(standings) && standings.length > 0;
+ // A race has no mode of its own, so it had no modeKey, so recordResult
+ // never ran and PB was missing from the multiplayer results entirely.
+ // Every race shares one key: the passage is whatever the server dealt, so
+ // a per-passage best would never be beaten twice.
+ const pbKey = modeKey || (isRace ? 'multiplayer' : null);
+ const { isNewBest, previous } = recordResult(pbKey, stats.wpm);
recordTest({ wpm: stats.wpm, accuracy: stats.accuracy, time: stats.time });
// Same exclusion as recordResult above: custom text/Zen have no stable,
// repeatable challenge, so there's no meaningful leaderboard entry for
@@ -48,7 +53,7 @@ export function renderEndScreen(root, { stats, text, attribution, explanation, s
// nothing to have beaten yet, so it just silently becomes the baseline.
// Sits under WPM alongside RAW, in the same label-over-value shape as
// every other secondary figure rather than as a floating badge.
- const pbLine = !modeKey || previous == null ? '' : isNewBest
+ const pbLine = !pbKey || previous == null ? '' : isNewBest
? '
PB
NEW BEST
'
: `
PB
${Math.round(previous)}
`;
@@ -56,7 +61,7 @@ export function renderEndScreen(root, { stats, text, attribution, explanation, s