From ea78f94027ecd2c690904a6d7729e9e3cc190a20 Mon Sep 17 00:00:00 2001 From: srdusr <99972264+srdusr@users.noreply.github.com> Date: Fri, 7 Nov 2025 14:04:00 +0200 Subject: Make tiling's master/stack ratio live, add settings readback everywhere Investigated the "tiling needs a lot of work" report directly. The MasterStackLayout algorithm itself was already correct; the real gap was that dragging or resizing a tiled window did nothing durable (raw geometry that the next arrange_workspace silently discarded), and master_ratio/master_count had no live path at all (config-file only). A resize-drag on the shared master/stack boundary now live-adjusts TilingConfig::master_ratio and re-arranges the group immediately; srd set master_ratio/master_count do the same for a keybind or script. Found and fixed a real bug while building this: start_resize's own focus_window call re-stacks its target in self.order before the ratio-drag decision used to be made, silently misclassifying real master-column grabs. Fixed by deciding ratio-drag status (and freezing the membership snapshot it depends on) before that raise happens, applying MasterStackLayout directly against the frozen snapshot rather than re-deriving membership from the by-then-reordered live order. Live- verified in a nested compositor, not just unit-tested. Also closes the readback gaps flagged directly by the AGS peer session: border_width/border_color/corner_radius/decoration_mode/gap_inner/ gap_outer/master_ratio/master_count were all live-settable via srd set with no way to read the current value back, and pin_input had no readback at all. SettingsResponse now reports all of them; a new pinned_inputs query (srd pinned inputs) lists every currently pinned pid/window. --- crates/wayland/src/virtual_pointer.rs | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'crates/wayland/src/virtual_pointer.rs') diff --git a/crates/wayland/src/virtual_pointer.rs b/crates/wayland/src/virtual_pointer.rs index e626e7d..f30d7fb 100644 --- a/crates/wayland/src/virtual_pointer.rs +++ b/crates/wayland/src/virtual_pointer.rs @@ -354,6 +354,11 @@ impl CompState { /// later way `set_output_position` already is (`WindowManager::drain_ /// pin_input_requests`). pub(crate) fn set_virtual_pointer_pin(&mut self, pid: i32, window: Option) { + // Real, applied state - not just the request that led here - so + // an IPC caller can read back "is pid X pinned to a window right + // now" instead of only ever writing blind. See `WindowManager:: + // set_pinned_window`'s own doc comment. + self.wm.borrow_mut().set_pinned_window(pid, window); self.virtual_pointers.retain(|p| p.is_alive()); let matching: Vec = self .virtual_pointers -- cgit v1.2.3